Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use M3 for CreateFolderDialog #12033

Merged
merged 5 commits into from
Oct 17, 2023
Merged

Use M3 for CreateFolderDialog #12033

merged 5 commits into from
Oct 17, 2023

Conversation

alperozturk96
Copy link
Collaborator

Before:

create_folder_before

After:

create_folder_after
  • [ Done ] Tests written, or not not needed

@alperozturk96
Update screenshots
9ad7130 
Signed-off-by: alperozturk <[email protected]>
AndyScherzinger
AndyScherzinger approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, tested on all OS themes 👍

AndyScherzinger
AndyScherzinger reviewed Oct 13, 2023
View reviewed changes
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screenshots aren't the ones matching the code change ;)

tobiasKaminsky
tobiasKaminsky approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@tobiasKaminsky tobiasKaminsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 let's wait for screenshot test

@alperozturk96
Copy link
Collaborator Author

Screenshots are updated

@alperozturk96
Copy link
Collaborator Author

/rebase

@tobiasKaminsky
Copy link
Member

Rebase did not worked due to conflict, you need to do it manually.

@alperozturk96
Merge master
751fa56 
Signed-off-by: alperozturk <[email protected]>
@github-actions
Copy link

Codacy

Lint

TypemasterPR
Warnings8080
Errors00

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness8585
Dodgy code434434
Experimental22
Internationalization99
Malicious code vulnerability22
Multithreaded correctness99
Performance5959
Security1818
Total644644

@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12033.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link

blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12033-Screenshot-blue-Light-07-34

@alperozturk96
Copy link
Collaborator Author

@tobiasKaminsky I did it manually but there are some inconsistencies in the screenshots tests. Could you check it and maybe create another PR to fix them?

@tobiasKaminsky tobiasKaminsky merged commit 7bde51b into master Oct 17, 2023
19 of 20 checks passed
@tobiasKaminsky tobiasKaminsky deleted the feature/use-m3-create-folder-dialog branch October 7, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

Assignees
No one assigned
Labels
3. to review design
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alperozturk96 @tobiasKaminsky @AndyScherzinger