Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/combine move and copy in menu #12026

Merged
merged 12 commits into from
Oct 30, 2023

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Oct 12, 2023

Resolves #2212

Move and copy file actions combined into one.

  • [ Done ] Tests written, or not not needed

@alperozturk96
Copy link
Collaborator Author

/rebase

@nextcloud-command nextcloud-command force-pushed the feature/combine-move-and-copy-in-menu branch from bb6f84b to 028e89c Compare October 16, 2023 11:43
@alperozturk96
Copy link
Collaborator Author

/rebase

1 similar comment
@alperozturk96
Copy link
Collaborator Author

/rebase

@AndyScherzinger
Copy link
Member

@joshtrichards
Copy link
Member

Associated with (and would close) #2212, no?

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lools very nice! Only one detail: "Move" should be the primary styled button instead of "Copy". :) Placement is good like this though.

@alperozturk96
Copy link
Collaborator Author

alperozturk96 commented Oct 20, 2023

@jancborchardt @AndyScherzinger In our web application button colors exactly same. Copy filled and Move tonal.

Web App

Screenshot 2023-10-20 at 12 01 42

Android App

3

I suggest we must sync so that we can preserve our design language across platforms.

We can change button colors in mobile app but web app must also do same thing or we can leave it as it is because web app already have same colors.

Signed-off-by: alperozturk <[email protected]>
@github-actions
Copy link

Codacy

Lint

TypemasterPR
Warnings7979
Errors00

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness8484
Dodgy code414414
Experimental22
Internationalization99
Malicious code vulnerability22
Multithreaded correctness99
Performance5858
Security1818
Total622622

@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12026.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndyScherzinger AndyScherzinger merged commit 84f3e6c into master Oct 30, 2023
20 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feature/combine-move-and-copy-in-menu branch October 30, 2023 18:36
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.27.0 milestone Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combine Move and Copy in menu
5 participants