-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/combine move and copy in menu #12026
Feature/combine move and copy in menu #12026
Conversation
/rebase |
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
bb6f84b
to
028e89c
Compare
/rebase |
1 similar comment
/rebase |
Looping in @jancborchardt for the designer feedback since you raised it, see https://github.com/nextcloud/android/pull/12026/files#diff-2e25592cb526aee4ed8eb25760a886ca36972b6111f2bfa2ab2595cd0d388d63 |
Associated with (and would close) #2212, no? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lools very nice! Only one detail: "Move" should be the primary styled button instead of "Copy". :) Placement is good like this though.
@jancborchardt @AndyScherzinger In our web application button colors exactly same. Copy filled and Move tonal. Web AppAndroid AppI suggest we must sync so that we can preserve our design language across platforms. We can change button colors in mobile app but web app must also do same thing or we can leave it as it is because web app already have same colors. |
Signed-off-by: alperozturk <[email protected]>
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12026.apk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves #2212
Move and copy file actions combined into one.