Unintended UI elements showing

[parneet-guraya]

Resolves #11700

• Tests written, or not not needed

• Fixes issues mentions in the issue.

• sortListGroup visibility handled by Stack. So, it does not go out of sync. Here's how it's handling -->

  • If going into a View which needs to have different visibility (either visible or not).
  • Then, we save the current visibility first and then change the visibility according to upcoming view
  • So, when going back we can pop out the visibility and we will have the correct visibility.
  • This way view visibility will never go out of sync (because of some unhandled case) and we will always have the correct visibility applied since we're saving it in a stack and popping out when going back.
  • It is somewhat like how Fragments are in backstack and going back they popes out.
  • Same way we're stacking up (when going in but only when we need to change the visibility) and popping out (handled to pop only for the cases where it needs to popped).

Before

Record_2023-09-12-22-05-52.mp4

After

VID_20230912190728.mp4

[parneet-guraya]

Also, here are the issues that I found while I was working on this PR (the issues mentioned are not introduced because of this PR). Issues -->

• Unintended toolbar type when going to rich preview of root directory. #11961
• FAB (Floating Action Button) does not change back when coming back from rich preview. #11962
• Cross icon should not show when the search view field is empty. #11963

I will be working on these issues. Other than that have a look on this PR and let me know if any changes required or any suggestions.
Thanks!

[parneet-guraya]

Hello team 👋, I'd appreciate it if someone could review my PR soon. Let me know if it needs changes.

Thanks! 😄

[ZetaTom]

Thanks for fixing this problem and explaining the rationale behind this solution. With this change in place, the UI behaves as expected and I haven't managed to break it again since.

The changes made to other files, including refactoring parts of FileDisplayActivity, are valid and a necessary effort. However, as we try to keep pull requests as modular as possible, I would suggest moving this to a separate branch if it's not too much trouble.

[parneet-guraya]

The changes made to other files, including refactoring parts of FileDisplayActivity, are valid and a necessary effort. However, as we try to keep pull requests as modular as possible, I would suggest moving this to a separate branch if it's not too much trouble.

Hi 👋 @ZetaTom , If I understood correctly you mean to have this commit (where I have did some refactoring) 5260ec7 to be in a separate branch? I may be wrong, if that's the case could you explain it what changes should be pushed in a separate branch?

[ZetaTom]

Hi 👋 @ZetaTom , If I understood correctly you mean to have this commit (where I have did some refactoring) 5260ec7 to be in a separate branch? I may be wrong, if that's the case could you explain it what changes should be pushed in a separate branch?

Yes, essentially extract those changes, and any changes not directly related to the issue at hand, into a separate pull request. This will make it easier to review and maintain in the future.

[parneet-guraya]

I got rid of the refactoring part. Check it out :-)

[parneet-guraya]

Hi, just following up on the changes I made for this PR. Could you please take a look when you get a chance?

Thanks!

[parneet-guraya]

Hi @AndyScherzinger 👋, I was wondering is there anything left to do before merging this? Already approved.

[AndyScherzinger]

@parneet-guraya all good I would say 👍 Let's merge when the checks have finished 👍

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	70	70
Errors	3	3

SpotBugs

Category	Base	New
Bad practice	26	26
Correctness	68	68
Dodgy code	360	360
Experimental	2	2
Internationalization	9	9
Malicious code vulnerability	2	2
Multithreaded correctness	9	9
Performance	55	55
Security	18	18
Total	549	549

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11965.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!