Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve address appearance in ImageDetailFragment #11938

Merged
merged 3 commits into from
Sep 4, 2023
Merged

Improve address appearance in ImageDetailFragment #11938

merged 3 commits into from
Sep 4, 2023

Conversation

ZetaTom
Copy link
Collaborator

@ZetaTom ZetaTom commented Sep 4, 2023

This change improves the appearance of addresses displayed within ImageDetailFragment by centring and constraining the displayed text to two lines. Furthermore, the photo pin has now been moved to a separate file in order to increase code legibility.

  • Tests written, or not not needed

@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.27.0 milestone Sep 4, 2023
@AndyScherzinger
Copy link
Member

/backport to stable-3.26

@AndyScherzinger AndyScherzinger merged commit 57326ea into master Sep 4, 2023
16 of 19 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/imagedetail-addresses branch September 4, 2023 16:40
@github-actions
Copy link

github-actions bot commented Sep 4, 2023

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11938.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/11938-Screenshot-blue-Light-17-05

AndyScherzinger added a commit that referenced this pull request Sep 4, 2023
@AndyScherzinger
Updated screenshot for #11938
730717c 
Signed-off-by: Andy Scherzinger <[email protected]>
AndyScherzinger added a commit that referenced this pull request Sep 4, 2023
@AndyScherzinger
Merge pull request #11940 from nextcloud/chore/noid/screenshotUpdate
68c64d6 
Updated screenshot for #11938
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 4, 2023
Merged
AndyScherzinger added a commit that referenced this pull request Sep 4, 2023
@AndyScherzinger
Updated screenshot for #11938
6bc9b57 
Signed-off-by: Andy Scherzinger <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees
No one assigned
Labels
3. to review feedback-requested
Projects
None yet
Milestone
Nextcloud App 3.27.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ZetaTom @AndyScherzinger