Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2e sharing #11922

Merged
merged 1 commit into from
Jan 16, 2024
Merged

E2e sharing #11922

merged 1 commit into from
Jan 16, 2024

Conversation

tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Aug 28, 2023 •
edited
Loading

  • Tests written, or not not needed

github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 29, 2023
View reviewed changes
app/src/main/java/com/owncloud/android/utils/EncryptionUtils.java
BadPaddingException, IllegalBlockSizeException,
CertificateException {

Cipher cipher = Cipher.getInstance(RSA_CIPHER);

Check failure

Code scanning / CodeQL

Use of a broken or risky cryptographic algorithm High

Cryptographic algorithm
RSA/ECB/OAEPWithSHA-256AndMGF1Padding
Loading
is weak and should not be used.
app/src/main/java/com/owncloud/android/utils/EncryptionUtils.java
BadPaddingException, IllegalBlockSizeException,
InvalidKeySpecException {

Cipher cipher = Cipher.getInstance(RSA_CIPHER);

Check failure

Code scanning / CodeQL

Use of a broken or risky cryptographic algorithm High

Cryptographic algorithm
RSA/ECB/OAEPWithSHA-256AndMGF1Padding
Loading
is weak and should not be used.
@tobiasKaminsky tobiasKaminsky added this to the Nextcloud App 3.26.0 milestone Aug 30, 2023
@tobiasKaminsky tobiasKaminsky removed this from the Nextcloud App 3.26.0 milestone Sep 8, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 11, 2024
View reviewed changes
app/src/main/java/com/owncloud/android/utils/EncryptionUtils.java
BadPaddingException, IllegalBlockSizeException,
InvalidKeySpecException {

Cipher cipher = Cipher.getInstance(RSA_CIPHER);

Check failure

Code scanning / CodeQL

Use of a broken or risky cryptographic algorithm High

Cryptographic algorithm
RSA/ECB/OAEPWithSHA-256AndMGF1Padding
Loading
is weak and should not be used.
@tobiasKaminsky tobiasKaminsky force-pushed the E2Esharing_rebased branch 3 times, most recently from abc64fa to 1f82432 Compare January 15, 2024 14:51
@nextcloud nextcloud deleted a comment from github-actions bot Jan 16, 2024
@tobiasKaminsky tobiasKaminsky force-pushed the E2Esharing_rebased branch 3 times, most recently from fc78e86 to 077226a Compare January 16, 2024 07:58
@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11922.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@tobiasKaminsky
extract tests
218fbd7 
Signed-off-by: tobiasKaminsky <[email protected]>
@github-actions GitHub Actions
Copy link

Codacy

Lint

TypemasterPR
Warnings6969
Errors33

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness7073
Dodgy code351360
Experimental22
Internationalization97
Malicious code vulnerability22
Multithreaded correctness66
Performance5454
Security1818
Total538548

SpotBugs increased!

@github-actions GitHub Actions
Copy link

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@tobiasKaminsky tobiasKaminsky merged commit 5be040c into master Jan 16, 2024
14 of 20 checks passed
@delete-merged-branch delete-merged-branch bot deleted the E2Esharing_rebased branch January 16, 2024 12:59
This was referenced Jan 26, 2024
Closed
Closed
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.28.0 milestone Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Nextcloud App 3.28.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tobiasKaminsky @AndyScherzinger