Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi-selection in shared tab #11788

Merged
merged 1 commit into from
Aug 12, 2023

Conversation

ZetaTom
Copy link
Collaborator

@ZetaTom ZetaTom commented Jul 4, 2023

This change addresses several issues related to multiple selection in the Shared tab.

Previously, when using Select All, files could be selected multiple times, leading to unexpected consequences. This behaviour should be fixed, along with other minor optimisations.


  • Tests written, or not not needed

@github-actions
Copy link

Codacy

Lint

TypemasterPR
Warnings7777
Errors00

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness8383
Dodgy code435435
Experimental22
Internationalization99
Malicious code vulnerability22
Multithreaded correctness99
Performance5656
Security1818
Total640640

@github-actions
Copy link

Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested successfully

@AndyScherzinger AndyScherzinger merged commit 43ee2a6 into master Aug 12, 2023
14 of 17 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/shared-tab-multi-selection branch August 12, 2023 15:12
@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11788.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants