Fix: Migrate OwncloudClient to NextCloudClient for empty trashbin #11738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
stable-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/9136-IT-stable-14-39 |
|
master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/9136-IT-master-14-44 |
1 task
AndyScherzinger
force-pushed
the
nmc/fixEmptyTrashbinFix
branch
from
1ed5dbe
to
1f8bff5
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11738.apk |
|
blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/11738-Screenshot-blue-Light-17-06 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite:
Steps to reproduce:
Reason of crash: EmptyTrashbinRemoteOpertation is using NextcloudClient for execution but while calling from RemoteTrashbinRepository OwncloudClient (deprecated) one is getting used.
Crash logs
Fix: Migrating the operation call from OwncloudClient to NextcloudClient.