Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaving shares: Menu action is "delete" in the context menu but web+iOS use "Leave this share" #7612

Open
weinic opened this issue Dec 6, 2020 · 2 comments
Labels
1. to develop enhancement feature: sharing Excluding: Sharing to/from the app from other Android apps

Comments

@weinic
Copy link

weinic commented Dec 6, 2020

In the app, shared folders for "delete" are displayed.
In the web browser, on the other hand, it is correct, as "cancel sharing"

In the App is it shown as this

Screenshot_20201204-152301__01__01

In the Webbrowser shows this the way it should be

Screenshot_20201204-152009__01

@weinic weinic added the bug label Dec 6, 2020
@tobiasKaminsky
Copy link
Member

@nextcloud/server-triage is this only a naming thing? Or do I really need to call a different endpoint?

@tobiasKaminsky tobiasKaminsky added needs info Waiting for info from user(s). Issues with this label will auto-stale. enhancement and removed bug labels Dec 16, 2020
@joshtrichards joshtrichards changed the title In the App shared folders are displayed to delete in the kontext menue In the App shared folders are displayed to delete in the context menue Oct 10, 2023
@joshtrichards joshtrichards changed the title In the App shared folders are displayed to delete in the context menue In the App shared folders are displayed to delete in the context menu Oct 10, 2023
@joshtrichards joshtrichards changed the title In the App shared folders are displayed to delete in the context menu In the App shared folders are displayed to "delete" in the context menu but web UI uses "cancel sharing" Oct 10, 2023
@joshtrichards joshtrichards added the feature: sharing Excluding: Sharing to/from the app from other Android apps label Oct 10, 2023
@joshtrichards
Copy link
Member

@tobiasKaminsky

Just a naming thing. Same WebDAV DELETE is called (e.g. 1 and 2). The menu item label is just changed based on being shared:

iOS:

https://github.com/nextcloud/ios/blob/f72360b27b25379e1220acffc338c2309dbf80e6/iOSClient/Menu/NCMenuAction.swift#L114-L120

Web:

https://github.com/nextcloud/server/blob/6d557569f6106f00867c970eeae2d8daa960e8be/apps/files/js/fileactions.js#L780-L792

Currently (in Android) we also pop up the "Keep / Local Only / Delete" dialog (which doesn't make sense) so we'll need to bypass that too.

Our current behavior in terms of the result - when choosing "Delete" + "Delete" - is correct though (Share disappears from sharee account + but original remains in sharer's account).

Note, today's language is "Leave this share" in both Web and iOS so that's what we should use.

@joshtrichards joshtrichards changed the title In the App shared folders are displayed to "delete" in the context menu but web UI uses "cancel sharing" Leaving shares: Menu action is "delete" in the context menu but web+iOS use "Leave this share" Dec 23, 2023
@joshtrichards joshtrichards removed the needs info Waiting for info from user(s). Issues with this label will auto-stale. label Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop enhancement feature: sharing Excluding: Sharing to/from the app from other Android apps
Projects
None yet
Development

No branches or pull requests

3 participants