Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check Usage of previousSortGroupState #12562

Closed
JonasMayerDev opened this issue Feb 14, 2024 · 1 comment · Fixed by #12584
Closed

Check Usage of previousSortGroupState #12562

JonasMayerDev opened this issue Feb 14, 2024 · 1 comment · Fixed by #12584
Labels
enhancement

Comments

@JonasMayerDev
Copy link
Collaborator 

          This would negate purpose of `previousSortGroupState`, which was introduced by #11965. If this choice was deliberate, check that *all* edge cases are handled appropriately and remove this variable entirely.

Originally posted by @ZetaTom in #12540 (comment)
@alperozturk96
Copy link
Collaborator

alperozturk96 commented Feb 14, 2024 •
edited
Loading

Handling visibility of Sort List Group with "Stack previousSortGroupState" not ideal. It caused crashed and wrong usage of showSortListGroup function. Crash has been fixed in this PR.

Things To Do

  1. Check usage of previousSortGroupState if its not necessary remove it.
  2. Decouple Sort List Group visibility from previousSortGroupState

@alperozturk96 alperozturk96 linked a pull request Feb 21, 2024 that will close this issue
Remove previousSortGroupState Usage For Set Visibility Of Sort List Group #12584
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove previousSortGroupState Usage For Set Visibility Of Sort List Group nextcloud/android
2 participants
@JonasMayerDev @alperozturk96