Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "\u0020" from a text string file_downloader_notification_title_prefix for Transifex #12180

Closed
Valdnet opened this issue Nov 16, 2023 · 4 comments · Fixed by #12189
Closed

Comments

@Valdnet
Copy link
Contributor

Valdnet commented Nov 16, 2023

You need to remove "\u0020" from the text string:

obraz

We don not want this at Transifex.

@joshtrichards
Copy link
Member

Was added in #12052:

<string name="file_downloader_notification_title_prefix">Downloading \u0020</string>

It's just a unicode space. I'm not up to speed on the translation stuff. It can't just get ignored like the variable substitutions already are (presumably) like here?

<string name="downloader_download_in_progress_content">%1$d%% Downloading %2$s</string>

@joshtrichards joshtrichards changed the title Remove "\u0020" from a text string Remove "\u0020" from a text string file_downloader_notification_title_prefix for Transifex Nov 17, 2023
@Valdnet
Copy link
Contributor Author

Valdnet commented Nov 17, 2023

Translators are accustomed to values such as %1$s. They know that this is a variable value that needs to be included in the translation.

However, not all translators see that it is a Unicode and should also be left in the translation.

@rakekniven What do you think?

@AndyScherzinger
Copy link
Member

Cc @alperozturk96

@rakekniven
Copy link
Member

It can't just get ignored like the variable substitutions already are (presumably) like here?

No, translators are not used to such unicode strings.

Some kind of placeholders or formatting strings like <br>, %s or %1 are really nice handled at Tx.
But unicode strings not :-(

@alperozturk96 alperozturk96 self-assigned this Nov 20, 2023
@alperozturk96 alperozturk96 linked a pull request Nov 20, 2023 that will close this issue
1 task
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.27.0 milestone Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants