From 47653afd9be5542b3a4fef6753b26015f6665800 Mon Sep 17 00:00:00 2001 From: Elv1zz Date: Mon, 13 Feb 2023 20:48:30 +0100 Subject: [PATCH] Replacing magic number by well-known constant Improving code quality a bit by avoiding magic numbers. Signed-off-by: Elv1zz --- .../java/com/owncloud/android/ui/NextcloudWebViewClient.kt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/com/owncloud/android/ui/NextcloudWebViewClient.kt b/app/src/main/java/com/owncloud/android/ui/NextcloudWebViewClient.kt index ad3ad143f667..639d2892df6c 100644 --- a/app/src/main/java/com/owncloud/android/ui/NextcloudWebViewClient.kt +++ b/app/src/main/java/com/owncloud/android/ui/NextcloudWebViewClient.kt @@ -15,6 +15,7 @@ import com.owncloud.android.lib.common.network.AdvancedX509KeyManager import com.owncloud.android.lib.common.network.NetworkUtils import com.owncloud.android.lib.common.utils.Log_OC import com.owncloud.android.ui.dialog.SslUntrustedCertDialog +import org.apache.commons.httpclient.HttpStatus import java.io.ByteArrayInputStream import java.security.cert.CertificateException import java.security.cert.CertificateFactory @@ -106,7 +107,7 @@ open class NextcloudWebViewClient(val supportFragmentManager: FragmentManager) : errorResponse: WebResourceResponse? ) { val errorCode = errorResponse?.statusCode ?: return - if (errorCode == 400) { + if (errorCode == HttpStatus.SC_BAD_REQUEST) { Log_OC.w(tag, "WebView failed with error code $errorCode; remove key chain aliases") // chosen client certificate alias does not seem to work -> discard it val failingUrl = request?.url ?: return