Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace used http client library #17

Open
AndyScherzinger opened this issue Sep 10, 2016 · 8 comments
Open

Replace used http client library #17

AndyScherzinger opened this issue Sep 10, 2016 · 8 comments

Comments

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Sep 10, 2016

At the moment the Nextcloud library uses a very old Apache http client library commons-httpclient-3.1. Thus I propose to move on to the latest stable release which is described here: https://hc.apache.org/httpcomponents-client-4.5.x/android-port.html - httpclient-android-4.3.5.1 targeting Android 22 or lower or httpclient-android-4.4.1.1 respectively targeting Android 23 of higher or use libraries like OkHttp, Volley or others.

cc @tobiasKaminsky for discussion on this topic

Asked for compatibility here: smarek/httpclient-android#12

@mario
Copy link
Contributor

mario commented Jan 16, 2017

Since there's JSON all around, maybe go for Retrofit?

@AndyScherzinger
Copy link
Member Author

Hi @mario unfortunately the issue here is related to the http client lib being a dependency of the used webdav client library (which is XML based) and there is no fully functional and supported webdav client lib except Jackrabbit (which uses a very old Apache http client library) 😞

@mario
Copy link
Contributor

mario commented Jan 16, 2017

@AndyScherzinger thanks for the clarification.

@PeterEdens
Copy link

I tried building with httpclient 4.3 but the ssl handshake problem still occurs.

@rpcameron
Copy link

Is the inability to use a current/modern httpc library the reason that chunked transfers are not supported? I'm trying to fully understand where this bug is rooted, as it makes the client unusable on Android if the server is using OpenBSD httpd, as all transfers are always marked as chunked (and the HTTP spec requires all clients to support chunked file encodings).

@AndyScherzinger
Copy link
Member Author

@rpcameron I'd guess no, since we support chunked uploads already. The inability to use a modern httpc lib prevents ipv6... :(

@rpcameron
Copy link

@AndyScherzinger The problem is not chunked uploads, but rather chunked downloads. On the Android client the file appears to download fine, but then fails. The issue in the client is that all chunked downloads fail, and has been acknowledged as the root for the error.

@tobiasKaminsky
Copy link
Member

This is being worked on right now: I switched get activity operation already to newest v2 system.

surinder-tsys added a commit to nextmcloud/android-library that referenced this issue Mar 1, 2023
…net.bytebuddy-byte-buddy-1.12.10

Bump byte-buddy from 1.12.9 to 1.12.10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants