[next] feat: Add spawnDialog function
#6207
Merged
+195
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot[bot]](https://avatars.githubusercontent.com/in/60201?s=60&v=4){kind=small}
backportbot
bot
added
enhancement
This allows to spawn a Vue dialog without the need of mounting the component. So it is possible to spawn a dialog directly from any JS code outside of components (e.g. callback functions). This method was originally taken from `@nextcloud/dialogs`, but I think it should belong to this Vue components library. Co-authored-by: Ferdinand Thiessen <[email protected]> Co-authored-by: Grigorii K. Shartsev <[email protected]> Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
backport/6195/next
branch
from
f205eb8
to
e0c7f1e
Compare
|
The docs are a bit hacky but with Vue3 we do not have a global instance, and the styleguide registers all components in one app.
|
susnux
approved these changes
Nov 11, 2024
ShGKme
requested changes
Nov 12, 2024
susnux
reviewed
Nov 13, 2024
Signed-off-by: Ferdinand Thiessen <[email protected]>
ShGKme
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #6195
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.