Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update beian URL #723

Merged
merged 2 commits into from
Dec 2, 2023
Merged

Update beian URL #723

merged 2 commits into from
Dec 2, 2023

Conversation

Leao9203
Copy link
Contributor

PR Checklist

PR Type

  • Bugfix.
  • Feature.
  • Improvement.
  • Code style update (formatting, linting).
  • Refactoring (no functional changes).
  • Documentation.
  • Translation.
  • Other... Please describe:

What is the current behavior?

Issue resolved:
The link of the MPS public query has been changed. This PR has changed the link of gongan_num to the new.

Copy link

welcome bot commented Nov 29, 2023

Thanks so much for opening your first PR here!

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@stevenjoezhang
Copy link
Member

_config.yml里面的http://www.beian.gov.cn也可以替换为https://beian.mps.gov.cn,然后http://www.beian.gov.cn/portal/download这个下载链接也可以删掉(或者看看有没有新的官方下载链接?)

@Leao9203
Copy link
Contributor Author

_config.yml里面的http://www.beian.gov.cn也可以替换为https://beian.mps.gov.cn,然后http://www.beian.gov.cn/portal/download这个下载链接也可以删掉(或者看看有没有新的官方下载链接?)

下载链接的话,目前好像是需要登录到 MPS 上才可以下载,而且似乎并不提供直接的 http 下载链接,最终是以一个 blob: 开头的链接保存的。可以直接把链接修改为 https://beian.mps.gov.cn/web/business/businessHome/website 吗?

Copy link

This pull request contains changes to the configuration file. Please make sure the documentation in NexT website is changed or added.
Please edit relevant source files here: https://github.com/next-theme/theme-next-docs/tree/master/source/docs and create a pull request with the changes here: https://github.com/next-theme/theme-next-docs/pulls

@stevenjoezhang
Copy link
Member

https://beian.mps.gov.cn/web/business/businessHome/website 这个没登录的话好像会重定向到首页,还是直接删掉好了

@stevenjoezhang stevenjoezhang added this to the 8.18.3 milestone Nov 29, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7035386669

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.416%

Totals Coverage Status
Change from base Build 6458994765: 0.0%
Covered Lines: 394
Relevant Lines: 399

💛 - Coveralls

@Leao9203
Copy link
Contributor Author

https://beian.mps.gov.cn/web/business/businessHome/website 这个没登录的话好像会重定向到首页,还是直接删掉好了

我是修改成这个样子了
图片

@stevenjoezhang stevenjoezhang changed the title Update footer.njk Update beian URL Nov 29, 2023
@stevenjoezhang
Copy link
Member

Thanks!

@Leao9203
Copy link
Contributor Author

Thanks!

It was nothing!

@stevenjoezhang stevenjoezhang merged commit d254d1a into next-theme:master Dec 2, 2023
9 of 13 checks passed
Copy link

welcome bot commented Dec 2, 2023

Congrats on merging your first pull request here! 🎉 How awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants