Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Energy cut applied before energy is redistributed in beersheba deconvolution #909

Open
jwaiton opened this issue Oct 24, 2024 · 0 comments

Comments

@jwaiton
Copy link
Collaborator

jwaiton commented Oct 24, 2024

In beersheba, the basic process for the deconvolution is as follows:

  • select z-slice for deconvolution
  • interpolate input for the deconvolution
  • apply the deconvolution
  • apply the e_cut to the output
  • repeat previous steps for all z-slices, then
  • redistributes the energies
  • returns the deconvolved event

The way this is done in Beersheba is a bit obtuse, but I'm happy to write out a more explicit explanation of how this is done.

I believe for the energy cut to have any meaning in the absolute case, the cut should be applied after the energies are redistributed, or e_cut should be renamed. This is because the cut you're applying is to the interpolated and then deconvolved data which is no longer cutting on energy explicitly. This is highlighted by the fact that you redistribute the energies after this cut is applied.

I'd be happy to discuss this issue further with anyone interested/more knowledgable with the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant