Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store time information in pmtrd and sipmrd #859

Open
gonzaponte opened this issue Feb 26, 2024 · 0 comments
Open

Store time information in pmtrd and sipmrd #859

gonzaponte opened this issue Feb 26, 2024 · 0 comments

Comments

@gonzaponte
Copy link
Collaborator

At the moment the time information is implicit and depends on the parameters of the city that generated the data. This is error-prone. We don't need to store the waveform times, but this wouldn't be too bad either, as it doesn't take a lot of space. I suggest we simply store the sampling time as a node attribute for now. The waveform times can be trivially obtained as np.arange(len(wf)) * sampling_time.

#837 would introduce the parameter used by the city, which would already implement this functionality indirectly. I would rather have it duplicated and attached to the relevant information as they serve different purposes. Perhaps we will see that this is unnecessary in the future and remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant