Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider renaming columns in pmaps hdf5 representation #846

Open
gonzaponte opened this issue Jan 11, 2024 · 2 comments
Open

Consider renaming columns in pmaps hdf5 representation #846

gonzaponte opened this issue Jan 11, 2024 · 2 comments

Comments

@gonzaponte
Copy link
Collaborator

Currently, we store npmt and nsipm as labels for the PMT and SiPM index in the per-sensor peak data, which is confusing.
@paolafer
Copy link
Collaborator

paolafer commented Jan 12, 2024 •
edited
Loading

Out of curiosity, why do we store the index instead of the ID? It seems more obscure to me. I mean, probably there was some reason behind when it was first implemented.

@gonzaponte
Copy link
Collaborator Author

why do we store the index instead of the ID?

I think it was a combination of ease of use and lack of experience with pandas. There are certainly more clear ways to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paolafer @gonzaponte