fix authoring coherence #295
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bthirion
reviewed
Feb 14, 2018
pypreprocess/slice_timing.py
Outdated
| :module: st | ||
| :synopsis: module for STC (Slice-Timing Correction) in fMRI data | ||
| :author: elvis[dot]dohmatob[at]inria[dot]fr | ||
| :Module: st |
There was a problem hiding this comment.
st -> slice timing, but I'd remove it for the sake of homogeneity.
bthirion
reviewed
Feb 14, 2018
| @@ -2,7 +2,7 @@ | |||
| """ | |||
| Created on Thu Aug 6 10:01:12 2015 | |||
|
|
|||
| @author: Mehdi RAHIM, Jerome DOCKES | |||
| :Author: RAHIM Mehdi, DOCKES Jerome | |||
| """ | |||
There was a problem hiding this comment.
Could you add a synopsis for the sake of homogeneity ?
bthirion
reviewed
Feb 14, 2018
pypreprocess/io_utils.py
Outdated
| @@ -1,7 +1,7 @@ | |||
| """ | |||
| :Module: utils | |||
There was a problem hiding this comment.
remove that one for the sake of homogeenity ?
SylvainLan
force-pushed
the
author_comment_2
branch
from
951bc47
to
becdf23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue #147
I used the way @dohmatob commented most of his files, namely:
There is still some incoherence, for instance whether or not I add the Module and/or the Synopsis to the header, which I could do.
I could also add another line for the author mail address