Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Py Bindings: Remove pointless borrowing of arguments #3033

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ferdonline
Copy link
Member

Context

Following the discussion in #3024 one better understood that

objects that are passed as arguments to C functions in an extension module that are called from Python; the call mechanism guarantees to hold a reference to every argument for the duration of the call.

(https://docs.python.org/3/c-api/intro.html#reference-counts)

Scope

Eliminate some unneeded borrows

@ferdonline ferdonline requested review from 1uc and mgeplf August 7, 2024 09:47
Copy link

sonarcloud bot commented Aug 7, 2024

Copy link

✔️ 96aba74 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.27%. Comparing base (94ee309) to head (96aba74).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3033      +/-   ##
==========================================
- Coverage   67.27%   67.27%   -0.01%     
==========================================
  Files         572      572              
  Lines      104923   104914       -9     
==========================================
- Hits        70587    70577      -10     
- Misses      34336    34337       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Oct 16, 2024

Copy link

✔️ c5bea14 -> Azure artifacts URL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants