Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review ref counting near Py2NRNString. #3022

Open
1uc opened this issue Jul 30, 2024 · 0 comments
Open

Review ref counting near Py2NRNString. #3022

1uc opened this issue Jul 30, 2024 · 0 comments

Comments

@1uc
Copy link
Collaborator

1uc commented Jul 30, 2024

During review of #3018, @mgeplf raised the question if the ref count needs to be preserved for Py2NRNString, for example this line here:

nrn/src/nrnpython/nrnpy_nrn.cpp

Line 1982 in ddf1bee

auto _pyname_tracker = nb::borrow(pyname); // keep refcount+1 during use

and likely several other occurrences (in the duplicated code section/segment & mech/no-mech).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@1uc