Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to federation mode when ENV variable misspelled #121

Open
surchs opened this issue Apr 11, 2024 · 1 comment
Open

Default to federation mode when ENV variable misspelled #121

surchs opened this issue Apr 11, 2024 · 1 comment
Labels
_flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again maint:usability General improvements to product usability that are unrelated to feature prioritization. type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs

Comments

@surchs
Copy link
Contributor

surchs commented Apr 11, 2024

Right now federation mode is the default if no env variable is defined. If a variable is defined but the value is not exactly "true", we set federation mode to false.

Instead we should set the federation mode to true unless the env variable is both defined and exactly "false"

@surchs surchs added maint:usability General improvements to product usability that are unrelated to feature prioritization. type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs labels Apr 11, 2024
Copy link

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 75 days.
We have applied the _flag:stale label to indicate that this issue should be reviewed again.
When you review, please reread the spec and then apply one of these three options:

  • prioritize: apply the flag:schedule label to suggest moving this issue into the backlog now
  • close: if the issue is no longer relevant, explain why (give others a chance to reply) and then close.
  • archive: sometimes an issue has important information or ideas but we won't work on it soon. In this case
    apply the someday label to show that this won't be prioritized. The stalebot will ignore issues with this
    label in the future. Use sparingly!

@github-actions github-actions bot added the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
_flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again maint:usability General improvements to product usability that are unrelated to feature prioritization. type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs
Projects
Status: No status
Development

No branches or pull requests

1 participant