Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase threshold for failed code coverage checks #173

Open
5 tasks
alyssadai opened this issue Oct 9, 2024 · 1 comment
Open
5 tasks

Increase threshold for failed code coverage checks #173

alyssadai opened this issue Oct 9, 2024 · 1 comment
Labels
maint:coverage Test coverage improvements that were not included in feature prioritization phase:research involves researching information on a topic rather than implementing specific feature. type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs

Comments

@alyssadai
Copy link
Contributor

alyssadai commented Oct 9, 2024

Let's use https://about.codecov.io/ consistently across repos and also increase threshold for failed checks.

At the moment, our code coverage checks (e.g., via coveralls) fail when coverage decreases by any amount. For example, see neurobagel/api@a93d476 which failed the coverage check due a 0.7% decrease.

To avoid possibly superfluous tests just for the sake of ensuring 0% coverage decrease, I propose we bump up the threshold so that coveralls / codecov only complains when coverage has decreased 1% or more.

@alyssadai alyssadai added maint:coverage Test coverage improvements that were not included in feature prioritization type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs flag:schedule Flag issue that should go on the roadmap or backlog. labels Oct 9, 2024
@surchs
Copy link
Contributor

surchs commented Oct 9, 2024

Could we make it relative to the PR rather than the codebase? I.e. we allow up to X% (maybe 20%?) of new or changed lines in a PR to be uncovered? % of the whole codebase is a bit harder to judge for me

@rmanaem rmanaem added phase:research involves researching information on a topic rather than implementing specific feature. and removed flag:schedule Flag issue that should go on the roadmap or backlog. labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maint:coverage Test coverage improvements that were not included in feature prioritization phase:research involves researching information on a topic rather than implementing specific feature. type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs
Projects
Status: Backlog
Development

No branches or pull requests

3 participants