Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute and show code coverage reports #649

Open
3 tasks
surchs opened this issue Nov 23, 2023 · 4 comments
Open
3 tasks

Compute and show code coverage reports #649

surchs opened this issue Nov 23, 2023 · 4 comments
Labels
_flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again maint:coverage Test coverage improvements that were not included in feature prioritization type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs

Comments

@surchs
Copy link
Contributor

surchs commented Nov 23, 2023

We have a nice test suite, we should have a coverage report. This should help: https://docs.cypress.io/guides/tooling/code-coverage

TODO:

  • Setup coverage with cypress
  • have a coverage report as part of the PR (like we do for python tools), e.g. codecov
  • show the coverage badge on the README
@surchs surchs added type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs maint:coverage Test coverage improvements that were not included in feature prioritization labels Nov 23, 2023
Copy link

github-actions bot commented Feb 7, 2024

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 75 days.
We have applied the _flag:stale label to indicate that this issue should be reviewed again.
When you review, please reread the spec and then apply one of these three options:

  • prioritize: apply the flag:schedule label to suggest moving this issue into the backlog now
  • close: if the issue is no longer relevant, explain why (give others a chance to reply) and then close.
  • archive: sometimes an issue has important information or ideas but we won't work on it soon. In this case
    apply the someday label to show that this won't be prioritized. The stalebot will ignore issues with this
    label in the future. Use sparingly!

@github-actions github-actions bot added the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Feb 7, 2024
@willtryagain
Copy link

Hi,

while installing code-coverage I am getting this error. Please guide how to proceed.

'Log files:
/home/a/.npm/_logs/2024-03-12T17_22_42_094Z-debug-0.log

npm resolution error report

While resolving: [email protected]
Found: [email protected]
node_modules/webpack
webpack@"^4.47.0" from the root project
peer webpack@"^4 || ^5" from @cypress/[email protected]
node_modules/@cypress/code-coverage
dev @cypress/code-coverage@"*" from the root project

Could not resolve dependency:
peer webpack@">=5" from [email protected]
node_modules/babel-loader
peer babel-loader@"^8.3 || ^9" from @cypress/[email protected]
node_modules/@cypress/code-coverage
dev @cypress/code-coverage@"*" from the root project

Fix the upstream dependency conflict, or retry
this command with --force or --legacy-peer-deps
to accept an incorrect (and potentially broken) dependency resolution.

@rmanaem
Copy link
Contributor

rmanaem commented Mar 13, 2024

Hi @willtryagain
Thanks for looking into this.
I believe we've come across this dependency conflict before while trying to set up code coverage. The annotation tool uses Nuxt 2 which uses Webpack 4 for its build process and since there is no official support for Webpack 5, upgrading is not an option see nuxt/nuxt#20055 (comment).
We plan to address this issue after transitioning the tool to React see neurobagel/query-tool#62.

As a side note If you'd like to work on an issue please ping one of the maintainers to let us know so we can avoid conflicts and give you the required context. For more information on how to contribute checkout the Neurobagel contributing guide.

@github-actions github-actions bot removed the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Mar 14, 2024
Copy link

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 75 days.
We have applied the _flag:stale label to indicate that this issue should be reviewed again.
When you review, please reread the spec and then apply one of these three options:

  • prioritize: apply the flag:schedule label to suggest moving this issue into the backlog now
  • close: if the issue is no longer relevant, explain why (give others a chance to reply) and then close.
  • archive: sometimes an issue has important information or ideas but we won't work on it soon. In this case
    apply the someday label to show that this won't be prioritized. The stalebot will ignore issues with this
    label in the future. Use sparingly!

@github-actions github-actions bot added the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
_flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again maint:coverage Test coverage improvements that were not included in feature prioritization type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs
Projects
Status: No status
Development

No branches or pull requests

3 participants