Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_encode_model_retriever() gets stuck while running on Windows #360

Open
ritugala opened this issue Sep 22, 2023 · 1 comment
Open

test_encode_model_retriever() gets stuck while running on Windows #360

ritugala opened this issue Sep 22, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@ritugala
Copy link
Collaborator

When using Windows, pytest gets stuck on this test, and it remains stuck till I dont manually abort the command. @viswavi speculates that maybe Tevatron doesn't support windows - I havent personally debugged around much

image
@ritugala ritugala added the bug Something isn't working label Sep 22, 2023
@ritugala
Copy link
Collaborator Author

ritugala commented Sep 22, 2023

Also there are issues running this test as well: test_retrieve_dataset_dict_when_search_index_exists() because temporary_files in windows cannot be opened again: https://stackoverflow.com/questions/23212435/permission-denied-to-write-to-my-temporary-file
Resolving this could be as simple as adding "delete=False" into the NamedTemporaryFile function, but it comes with the tradeoff that these temporary files would then need to be manually deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant