From a9a5cff35ea47281862e7e08ea4fd46cb7632017 Mon Sep 17 00:00:00 2001 From: Graham Neubig Date: Tue, 26 Apr 2022 11:06:06 -0400 Subject: [PATCH 1/2] Update name of fig_qa --- backend/src/impl/private_dataset.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/backend/src/impl/private_dataset.py b/backend/src/impl/private_dataset.py index d37e7240..0a0b2a44 100644 --- a/backend/src/impl/private_dataset.py +++ b/backend/src/impl/private_dataset.py @@ -2,7 +2,7 @@ from explainaboard import DatalabLoaderOption -PRIVATE_DATASETS = [DatalabLoaderOption("metaphor_qa", None, "test")] +PRIVATE_DATASETS = [DatalabLoaderOption("fig_qa", None, "test")] _private_dataset_lookup = set(astuple(dataset) for dataset in PRIVATE_DATASETS) From 86984f141606cc84ad04af5c467f62da95e5452e Mon Sep 17 00:00:00 2001 From: Lyuyang Hu Date: Tue, 26 Apr 2022 13:37:58 -0400 Subject: [PATCH 2/2] use (dataset, split) to determine private dataset --- backend/src/impl/private_dataset.py | 8 ++++---- frontend/src/pages/LeaderboardPage/index.tsx | 8 +++++++- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/backend/src/impl/private_dataset.py b/backend/src/impl/private_dataset.py index 0a0b2a44..528e4236 100644 --- a/backend/src/impl/private_dataset.py +++ b/backend/src/impl/private_dataset.py @@ -1,11 +1,11 @@ -from dataclasses import astuple - from explainaboard import DatalabLoaderOption PRIVATE_DATASETS = [DatalabLoaderOption("fig_qa", None, "test")] -_private_dataset_lookup = set(astuple(dataset) for dataset in PRIVATE_DATASETS) +_private_dataset_lookup = set( + (dataset.dataset, dataset.split) for dataset in PRIVATE_DATASETS +) def is_private_dataset(dataset: DatalabLoaderOption): - return astuple(dataset) in _private_dataset_lookup + return (dataset.dataset, dataset.split) in _private_dataset_lookup diff --git a/frontend/src/pages/LeaderboardPage/index.tsx b/frontend/src/pages/LeaderboardPage/index.tsx index afa6a592..cd82314f 100644 --- a/frontend/src/pages/LeaderboardPage/index.tsx +++ b/frontend/src/pages/LeaderboardPage/index.tsx @@ -22,7 +22,13 @@ export function LeaderboardPage() { const subdataset = query.get("subdataset") || undefined; if (task || dataset || subdataset) { - const title = subdataset || dataset || task; + let title = ""; + if (dataset) { + title = dataset; + if (subdataset) title += ` (${subdataset})`; + } else if (task) { + title = task; + } let subTitle; if (subdataset) { subTitle = `subdataset: ${subdataset}`;