Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

来自学弟90%的汉化 #46

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

NearlyHeadlessJack
Copy link

第一次用pr有点紧张。。。
secret不知道是不是用来本地加密数据用的,所以没敢乱翻译。其他部分大多数都翻译了一遍。❤️

Comment on lines 64 to 65
if strings.Contains(body, "Arrearage users") {
return fmt.Errorf("overdue")
if strings.Contains(body, "欠费用户") {
return fmt.Errorf("超时")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里 Arrearage users 是网关 api 返回的固定内容,不能翻译;后面的 overdue 应该翻译成”已超额“或”已欠费“。

@amtoaer
Copy link
Member

amtoaer commented Dec 25, 2021

先指出个比较明显的错误,其它部分等翻译结束后再细看。
个人感觉还有两点小问题:

  1. 翻译只翻译了文本,相邻的标点符号没有翻译
  2. 翻译后中英文间没有空格

只是个人看法,具体要怎样做还是等等白的意见吧。🤣

@unbyte
Copy link
Member

unbyte commented Dec 25, 2021

有更新直接push到提起pr的branch上就行了,不用每次新改动都开一个新pr
我有时间再review一下

@NearlyHeadlessJack NearlyHeadlessJack marked this pull request as ready for review December 26, 2021 15:23
@NearlyHeadlessJack
Copy link
Author

NearlyHeadlessJack commented Dec 26, 2021 via email

@unbyte unbyte marked this pull request as draft December 28, 2021 16:33
@unbyte
Copy link
Member

unbyte commented Dec 28, 2021

暂时 hang 住,下周出个版本带上语言切换

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants