Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do We Need Custom Flow Control or Congestion Control? #739

Open
blueuuufish opened this issue Jul 29, 2024 · 2 comments
Open

Do We Need Custom Flow Control or Congestion Control? #739

blueuuufish opened this issue Jul 29, 2024 · 2 comments

Comments

@blueuuufish
Copy link

Is it necessary to implement any custom flow control mechanisms or congestion control at the Netty layer, or does the quiche library handle these internally?Thanks!

@blueuuufish
Copy link
Author

In Netty's HTTP/2 implementation, Netty provides the flowController interface. In RPC documentation, the MAX_DATA frame is mentioned for flow control, which is implemented in the Rust-based quiche library. However, in Netty-QUIC, there is no equivalent interface, although similar flow control logic exists in QuicheQuicStreamChannel. Additionally, it appears that the quiche library does not expose related interfaces.

Could you please advise if Netty's QUIC protocol implementation should include a flowController interface to achieve more efficient flow control?

Thanks!

@normanmaurer
Copy link
Member

@blueuuufish all the flowcontrol is basically handled by quiche itself which will tell netty when it can send more data or not. So I think there is really not much we can provide here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants