Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tinyint should probably be a number not a boolean #9

Closed
naseemkullah opened this issue Jan 18, 2021 · 4 comments
Closed

tinyint should probably be a number not a boolean #9

naseemkullah opened this issue Jan 18, 2021 · 4 comments

Comments

@naseemkullah
Copy link
Collaborator

naseemkullah commented Jan 18, 2021 •
edited
Loading

mysql-schema-ts/src/column-map.ts

Lines 42 to 43 in 711b641

case 'tinyint':
column.tsType = 'boolean'

There are cases where it can go beyond 0 or 1 (up to 255), thoughts?
@naseemkullah naseemkullah changed the title tinyint should probably be a number not a boolean tinyint can be a number in some cases, not always boolean Jan 18, 2021
@naseemkullah naseemkullah changed the title tinyint can be a number in some cases, not always boolean tinyint should probably be a number nota boolean Jan 18, 2021
@naseemkullah naseemkullah changed the title tinyint should probably be a number nota boolean tinyint should probably be a number not a boolean Jan 18, 2021
@naseemkullah naseemkullah mentioned this issue Jan 18, 2021
Merged
@naseemkullah
Copy link
Collaborator Author

#10 created if maintainers agree

@naseemkullah
Copy link
Collaborator Author

https://github.com/mysqljs/mysql#type-casting

Also see SweetIQ/schemats#116 (comment)

@naseemkullah
Copy link
Collaborator Author

Bump

@nettofarah
Copy link
Owner

That's a good idea! I'm down with it :)

@dweekly dweekly mentioned this issue Oct 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nettofarah @naseemkullah