Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional tunnel encapsulation choices: PPTP, L2TP, EoIP, SSTP #17960

Open
jmcguir opened this issue Nov 7, 2024 · 2 comments
Open

Add additional tunnel encapsulation choices: PPTP, L2TP, EoIP, SSTP #17960

jmcguir opened this issue Nov 7, 2024 · 2 comments
Labels
status: needs triage This issue is awaiting triage by a maintainer type: feature Introduction of new functionality to the application

Comments

@jmcguir
Copy link
Contributor

jmcguir commented Nov 7, 2024

NetBox version

v4.1.4

Feature type

Change to existing functionality

Triage priority

I volunteer to perform this work (if approved)

Proposed functionality

I'd like to add PPTP, L2TP, and EoIP as Tunnel Encapsulation Choices. PPTP, and L2TP are standards based tunnel protocols while EoIP is a MikroTik proprietary protocol and SSTP is a Microsoft proprietary protocol.

PPTP: https://datatracker.ietf.org/doc/html/rfc2637
L2TP: https://datatracker.ietf.org/doc/html/rfc2661
EoIP: https://help.mikrotik.com/docs/spaces/ROS/pages/24805521/EoIP
SSTP: https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms-sstp/c50ed240-56f3-4309-8e0c-1644898f0ea8

As far as I can tell the only change here would be to add these fourto the choices.py here: https://github.com/netbox-community/netbox/blob/develop/netbox/vpn/choices.py

Use case

This lets users model more accurately their VPN tunnels. Right now the choices don't have an other so you have to use an incorrect Encapsulation choice.

Database changes

No response

External dependencies

No response

@jmcguir jmcguir added status: needs triage This issue is awaiting triage by a maintainer type: feature Introduction of new functionality to the application labels Nov 7, 2024
@chbally
Copy link

chbally commented Nov 7, 2024

Please also add WireGuard:
WireGuard: https://datatracker.ietf.org/doc/html/rfc8922#name-wireguard
and if possible OpenVPN:
OpenVPN: https://datatracker.ietf.org/doc/html/rfc8922#name-openvpn

I think even if is kind of IP in IP lots of people would appreciate these two protokolls in Netbox:
#14683

@jmcguir jmcguir changed the title Add additional tunnel encapsulation choices: PPTP, L2TP, EoIP Add additional tunnel encapsulation choices: PPTP, L2TP, EoIP, SSTP Nov 12, 2024
@jmcguir
Copy link
Contributor Author

jmcguir commented Nov 12, 2024

If approved I'd be happy to add WireGuard and OpenVPN to a PR I'm willing to write.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs triage This issue is awaiting triage by a maintainer type: feature Introduction of new functionality to the application
Projects
None yet
Development

No branches or pull requests

2 participants