Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Significant performance improvements, URDF refactor #67

Merged
merged 36 commits into from
Jul 24, 2023
Merged

Conversation

brentyi
Copy link
Collaborator

@brentyi brentyi commented Jul 20, 2023

This builds on #63, so the diff will be messy until that's merged.

A handful of changes:

  • Added viser.extras.ViserUrdf, which is a light wrapper around the relevant yourdfpy + viser APIs for visualizing URDF files.
  • Significant performance improvements when we have a lot of messages. The largest change here is a TCP-inspired windowing implementation, which has a big impact on client-side deserialization overhead. This helps a lot for things like real-time visualization of camera pose optimization or high-dimensional robot states (for many robots).
  • More robust .atomic() implementation. The previous one had some race conditions related to culling for redundant messages, and would fail for high message volumes.

brentyi added 30 commits July 8, 2023 20:36
@brentyi brentyi marked this pull request as ready for review July 21, 2023 04:51
@brentyi brentyi changed the title URDF refactor + related low-level improvements & fixes Significant performance improvements, URDF refactor Jul 24, 2023
@brentyi brentyi merged commit e02410f into main Jul 24, 2023
11 checks passed
@brentyi brentyi deleted the brent/urdf_helper branch July 24, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant