Farewell, Leva #52
Merged
Farewell, Leva #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
you were good to us
brentyi
force-pushed
the
brent/farewell_leva
branch
from
716b8cc
to
b1c2a9a
Compare
chungmin99
reviewed
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves us away from Leva for generated UI components. We have feature parity with the Leva-based UI generation, and it should put us in a nice place for adding more capabilities (tabs, 2D image display, ...).
Code is a little bit chaotic, but a lot of it will need to be refactored anyways. 🙂
Before:
After:
Before:
After:
Before:
After:
