Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrix not positive #263

Open
LaFeuilleMorte opened this issue Aug 14, 2024 · 3 comments
Open

Matrix not positive #263

LaFeuilleMorte opened this issue Aug 14, 2024 · 3 comments

Comments

@LaFeuilleMorte
Copy link

Thanks for open-sourcing this great work! I've encountered "matrix not positive defined" error in using cholesky decomposition here. As I dig deeper, I found that the covariance matrix has NaN values. So I replace NaN with 0, and add a small eye matrix to make the matrix positive defined. The ply has been successfully loaded but it failed to render the ply file. Can you give me some suggestions. This https://github.com/mkkellogg/GaussianSplats3D/ viewer is able to render my ply file successfully.
image

@LaFeuilleMorte
Copy link
Author

Oh, I think I've found what's wrong in the code. My ply file has gaussians that contains NaN values in the scale and rotate. So it will trigger the matrix not positive defined error. One easy fix would be filtering gaussians that have bad values:
image

@brentyi
Copy link
Collaborator

brentyi commented Aug 14, 2024

Interesting yeah, we currently assume all covariance inputs are valid. Can I ask where you got your PLY file from? We could also add the filtering on our end.

If you have any other issues with the Gaussian rendering please do let us know, it's very much in an experimental phase right now!

@LaFeuilleMorte
Copy link
Author

Interesting yeah, we currently assume all covariance inputs are valid. Can I ask where you got your PLY file from? We could also add the filtering on our end.

If you have any other issues with the Gaussian rendering please do let us know, it's very much in an experimental phase right now!

Not the vanilla 3DGS. It's from PGSR: PGSR: Planar-based Gaussian Splatting for Efficient and High-Fidelity Surface Reconstruction. I guess this method might introduce some gaussians with NaN values during optimization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants