Moving speed adjustment

[wuzirui]

Hi, thanks for making this open-sourced! Just wonder whether we can adjust the camera moving speed via viser commands. Sometimes the reconstructed scenes are large but the moving speed is too slow, how can I speed up? Thanks!

[brentyi]

Hi, do you mean the arrow key controls?

If so the velocities are unfortunately hardcoded, you could adjust them here:

viser/src/viser/client/src/CameraControls.tsx

Lines 133 to 192 in b947d24

	const wKey = new holdEvent.KeyboardKeyHold("KeyW", 20);
	const aKey = new holdEvent.KeyboardKeyHold("KeyA", 20);
	const sKey = new holdEvent.KeyboardKeyHold("KeyS", 20);
	const dKey = new holdEvent.KeyboardKeyHold("KeyD", 20);
	const qKey = new holdEvent.KeyboardKeyHold("KeyQ", 20);
	const eKey = new holdEvent.KeyboardKeyHold("KeyE", 20);
	// TODO: these event listeners are currently never removed, even if this
	// component gets unmounted.
	aKey.addEventListener("holding", (event) => {
	cameraControls.truck(-0.002 * event?.deltaTime, 0, true);
	});
	dKey.addEventListener("holding", (event) => {
	cameraControls.truck(0.002 * event?.deltaTime, 0, true);
	});
	wKey.addEventListener("holding", (event) => {
	cameraControls.forward(0.002 * event?.deltaTime, true);
	});
	sKey.addEventListener("holding", (event) => {
	cameraControls.forward(-0.002 * event?.deltaTime, true);
	});
	qKey.addEventListener("holding", (event) => {
	cameraControls.elevate(-0.002 * event?.deltaTime, true);
	});
	eKey.addEventListener("holding", (event) => {
	cameraControls.elevate(0.002 * event?.deltaTime, true);
	});
	const leftKey = new holdEvent.KeyboardKeyHold("ArrowLeft", 20);
	const rightKey = new holdEvent.KeyboardKeyHold("ArrowRight", 20);
	const upKey = new holdEvent.KeyboardKeyHold("ArrowUp", 20);
	const downKey = new holdEvent.KeyboardKeyHold("ArrowDown", 20);
	leftKey.addEventListener("holding", (event) => {
	cameraControls.rotate(
	-0.05 * THREE.MathUtils.DEG2RAD * event?.deltaTime,
	0,
	true,
	);
	});
	rightKey.addEventListener("holding", (event) => {
	cameraControls.rotate(
	0.05 * THREE.MathUtils.DEG2RAD * event?.deltaTime,
	0,
	true,
	);
	});
	upKey.addEventListener("holding", (event) => {
	cameraControls.rotate(
	0,
	-0.05 * THREE.MathUtils.DEG2RAD * event?.deltaTime,
	true,
	);
	});
	downKey.addEventListener("holding", (event) => {
	cameraControls.rotate(
	0,
	0.05 * THREE.MathUtils.DEG2RAD * event?.deltaTime,
	true,
	);
	});

[wuzirui]

Hi, do you mean the arrow key controls?

If so the velocities are unfortunately hardcoded, you could adjust them here:

viser/src/viser/client/src/CameraControls.tsx

Lines 133 to 192 in b947d24

	const wKey = new holdEvent.KeyboardKeyHold("KeyW", 20);
	const aKey = new holdEvent.KeyboardKeyHold("KeyA", 20);
	const sKey = new holdEvent.KeyboardKeyHold("KeyS", 20);
	const dKey = new holdEvent.KeyboardKeyHold("KeyD", 20);
	const qKey = new holdEvent.KeyboardKeyHold("KeyQ", 20);
	const eKey = new holdEvent.KeyboardKeyHold("KeyE", 20);
	// TODO: these event listeners are currently never removed, even if this
	// component gets unmounted.
	aKey.addEventListener("holding", (event) => {
	cameraControls.truck(-0.002 * event?.deltaTime, 0, true);
	});
	dKey.addEventListener("holding", (event) => {
	cameraControls.truck(0.002 * event?.deltaTime, 0, true);
	});
	wKey.addEventListener("holding", (event) => {
	cameraControls.forward(0.002 * event?.deltaTime, true);
	});
	sKey.addEventListener("holding", (event) => {
	cameraControls.forward(-0.002 * event?.deltaTime, true);
	});
	qKey.addEventListener("holding", (event) => {
	cameraControls.elevate(-0.002 * event?.deltaTime, true);
	});
	eKey.addEventListener("holding", (event) => {
	cameraControls.elevate(0.002 * event?.deltaTime, true);
	});
	const leftKey = new holdEvent.KeyboardKeyHold("ArrowLeft", 20);
	const rightKey = new holdEvent.KeyboardKeyHold("ArrowRight", 20);
	const upKey = new holdEvent.KeyboardKeyHold("ArrowUp", 20);
	const downKey = new holdEvent.KeyboardKeyHold("ArrowDown", 20);
	leftKey.addEventListener("holding", (event) => {
	cameraControls.rotate(
	-0.05 * THREE.MathUtils.DEG2RAD * event?.deltaTime,
	0,
	true,
	);
	});
	rightKey.addEventListener("holding", (event) => {
	cameraControls.rotate(
	0.05 * THREE.MathUtils.DEG2RAD * event?.deltaTime,
	0,
	true,
	);
	});
	upKey.addEventListener("holding", (event) => {
	cameraControls.rotate(
	0,
	-0.05 * THREE.MathUtils.DEG2RAD * event?.deltaTime,
	true,
	);
	});
	downKey.addEventListener("holding", (event) => {
	cameraControls.rotate(
	0,
	0.05 * THREE.MathUtils.DEG2RAD * event?.deltaTime,
	true,
	);
	});

Thanks for your prompt feedback! Yes, exactly, is it possible to make this a configurable parameter? cuz today's gaussian splats are usually used in realworld scales (and unit scales). using a hard coded speed would be a bit inconvenient.

[brentyi]

Yeah, the scale assumption is unideal. Would addressing #14 also solve this for you?

[wuzirui]

Yes, it could also be a proper solution, I totally agree.