Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for automountServiceAccountToken to serviceaccount.yaml template #54

Closed
elijah opened this issue Mar 25, 2024 · 1 comment

Comments

@elijah
Copy link
Contributor

elijah commented Mar 25, 2024

I needed to add this to quiet a Kyverno warning in one of our YACE deployments - figured that pushing the work upstream was a good idea.

Any suggestions you have for how this should be supported in the YACE helm chart, i'd be happy to take a stab at implementing.

I initially had an "if" block wrapped around the automountServiceAccountTokens: statement in the template, but one of my coworkers pointed out that the default in k8s seems to often by true - so the if block would make more sense if we just overrode the default with "false" to get the behavior that we want.

@cristiangreco
Copy link
Collaborator

Thanks for your contribution in #53

This will be released with chart version 0.33.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants