Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker build/push postsubmit jobs #782

Merged
merged 11 commits into from
Aug 27, 2024

Conversation

efiacor
Copy link
Contributor

@efiacor efiacor commented Jul 29, 2024

Docker build jobs for nephio are currently in the test-infra project.
https://github.com/nephio-project/test-infra/blob/f90ff7bca6f1f51a6e72c56caa6fd3d01b225733/prow/config/config.yaml#L1640
These should live along side the nephio code.

Copy link
Member

@liamfallon liamfallon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@nephio-prow nephio-prow bot added the approved label Jul 29, 2024
@vjayaramrh
Copy link
Contributor

FYI reviewed the changes

@kispaljr
Copy link
Contributor

Haven't tested it, but just by reading through the changes it looks good

.prow.yaml Outdated Show resolved Hide resolved
.prow.yaml Outdated Show resolved Hide resolved
.prow.yaml Outdated Show resolved Hide resolved
.prow.yaml Outdated Show resolved Hide resolved
.prow.yaml Outdated Show resolved Hide resolved
.prow.yaml Outdated Show resolved Hide resolved
.prow.yaml Outdated Show resolved Hide resolved
.prow.yaml Outdated Show resolved Hide resolved
.prow.yaml Outdated Show resolved Hide resolved
.prow.yaml Outdated Show resolved Hide resolved
efiacor and others added 7 commits August 26, 2024 10:24
Co-authored-by: Rado Chmiel <[email protected]>
Co-authored-by: Rado Chmiel <[email protected]>
Co-authored-by: Rado Chmiel <[email protected]>
Co-authored-by: Rado Chmiel <[email protected]>
Co-authored-by: Rado Chmiel <[email protected]>
Co-authored-by: Rado Chmiel <[email protected]>
Co-authored-by: Rado Chmiel <[email protected]>
efiacor and others added 3 commits August 26, 2024 10:25
Co-authored-by: Rado Chmiel <[email protected]>
Co-authored-by: Rado Chmiel <[email protected]>
Co-authored-by: Rado Chmiel <[email protected]>
Copy link
Member

@liamfallon liamfallon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Copy link
Contributor

nephio-prow bot commented Aug 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot merged commit f58266c into nephio-project:main Aug 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants