Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porch migration to Nephio #465

Closed
9 of 17 tasks
johnbelamaric opened this issue Dec 19, 2023 · 7 comments
Closed
9 of 17 tasks

Porch migration to Nephio #465

johnbelamaric opened this issue Dec 19, 2023 · 7 comments
Assignees
Labels
Milestone

Comments

@johnbelamaric
Copy link
Member

johnbelamaric commented Dec 19, 2023

Tracking issue for the migration discussed here: #450

Migration

Clean Up

  • Remove unused controllers
  • Move fleet-sync GCP-specific controller to a separate repo, and consider re-instating other GCP-specific controllers if desired
  • Remove the "Task List" concept from PackageRevision
  • Remove the Function CRD, as we are not using it
  • Remove the "Package" CRD, as it is not fully implemented
  • Consider removing OCI support. We don't use it today, and it is not as well exercised as the Git support
@johnbelamaric
Copy link
Member Author

For the Porch e2e tests, it does some of them now but not the ones that require a cluster. We need:

  • Image build and push working for PRs for the nephio-project/porch repo
  • The make ci-test-porch needs to create a Kind cluster, deploy the code (make deploy), then set E2E=1 and do the make test. Right now, it doesn't set E2E so those tests are skipped.

See also
nephio-project/porch#4 (comment) and the subsequent comments.

@johnbelamaric
Copy link
Member Author

@electrocucaracha can you help with the above?

@johnbelamaric
Copy link
Member Author

Once this is done, we will want to update the docs to all use porchctl instead of kpt alpha. We will still use kpt for some things (like function execution, etc.).

@efiacor
Copy link
Contributor

efiacor commented Feb 19, 2024

Once this is done, we will want to update the docs to all use porchctl instead of kpt alpha. We will still use kpt for some things (like function execution, etc.).

Done

@efiacor
Copy link
Contributor

efiacor commented Feb 19, 2024

For the Porch e2e tests, it does some of them now but not the ones that require a cluster. We need:

* Image build and push working for PRs for the nephio-project/porch repo

* The `make ci-test-porch` needs to create a Kind cluster, deploy the code (`make deploy`), then set `E2E=1` and do the `make test`. Right now, it doesn't set `E2E` so those tests are skipped.

See also nephio-project/porch#4 (comment) and the subsequent comments.

PR raised here - nephio-project/porch#21

@liamfallon liamfallon added the area/porch Porch related issues label Mar 12, 2024
@efiacor efiacor added this to R4 May 14, 2024
@liamfallon
Copy link
Member

Triaged
Triage Comment: Complete in R3

@efiacor
Copy link
Contributor

efiacor commented Nov 12, 2024

Closing with the following exceptions.

Outstanding items:

@efiacor efiacor closed this as completed Nov 12, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in R4 Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

3 participants