Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/issue 149 wiki page version #151

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

heieisch
Copy link
Contributor

Description

fix issue 149 as discussed. Adds the version parameter to the allowed_params, so the requester can access it.

now with correct branch name

References

GitHub issue 149 fixed

Checklist

  • I have read the contribution guide
  • Code lint checked via inv lint
  • changes file included (see docs)
  • Usage documentation added in case of new features
  • Tests added

@coveralls
Copy link

Coverage Status

coverage: 97.921%. remained the same when pulling 6fac4d0 on heieisch:bugfix/issue-149-WikiPage-version into 7d717c6 on nephila:master.

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7d717c6) 96.49% compared to head (6fac4d0) 96.49%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #151   +/-   ##
=======================================
  Coverage   96.49%   96.49%           
=======================================
  Files           8        8           
  Lines         914      914           
  Branches       69       69           
=======================================
  Hits          882      882           
  Misses         19       19           
  Partials       13       13           
Flag Coverage Δ
unittests 96.49% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
taiga/models/models.py 96.53% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@protoroto protoroto merged commit a83ef72 into nephila:master Oct 16, 2023
27 of 30 checks passed
@protoroto
Copy link
Member

@heieisch I'm about to release a new version with your fix, and I wanted to update the AUTHORS file with your name and email, if you're ok with that, but I don't know them :) if you want to be included, please write them here (or if you prefer, via email at [email protected] ) Thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wiki Page update fails due to Version number
3 participants