Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upade WikiPage #150

Closed
wants to merge 2 commits into from

Conversation

heieisch
Copy link
Contributor

@heieisch heieisch commented Oct 13, 2023

Description

fix issue 149 as discussed. Adds the version parameter to the allowed_params, so the requester can access it.

References

GitHub issue 149 fixed

Checklist

  • I have read the contribution guide
  • Code lint checked via inv lint
  • changes file included (see docs)
  • Usage documentation added in case of new features
  • Tests added

@coveralls
Copy link

Coverage Status

coverage: 97.921%. remained the same when pulling 6fac4d0 on heieisch:issue-149-WikiPage-version into 7d717c6 on nephila:master.

@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7d717c6) 96.49% compared to head (6fac4d0) 96.49%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #150   +/-   ##
=======================================
  Coverage   96.49%   96.49%           
=======================================
  Files           8        8           
  Lines         914      914           
  Branches       69       69           
=======================================
  Hits          882      882           
  Misses         19       19           
  Partials       13       13           
Flag Coverage Δ
unittests 96.49% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
taiga/models/models.py 96.53% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@protoroto
Copy link
Member

@heieisch Thanks for this pr! Tests are failing because the branch name should be bugfix/issue-149-WikiPage-version, otherwise towncrier will complain.
If you change the branch name (I don't know if github will let you do that, but you can open another pr with the correct branch name and close this if it doesn't let you change the branch name), I'll try to merge this and release a new version as soon as possible.

@heieisch heieisch closed this Oct 15, 2023
@heieisch heieisch deleted the issue-149-WikiPage-version branch October 15, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wiki Page update fails due to Version number
3 participants