Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/multi project leaking #167

Merged
merged 8 commits into from
May 13, 2024
Merged

Fix/multi project leaking #167

merged 8 commits into from
May 13, 2024

Conversation

marchermans
Copy link
Contributor

@marchermans marchermans commented May 13, 2024

TLDR

Due to the way we register dependencies on replacement it is possible that the target configuration still leaks information.
This replaces this by properly looking up the relevant compileOnly and runtimeOnly configurations.

Changes:

  • Fixes to how configurations are looked up from a root configuration (aka implementation -> compileOnly etc)
  • Implement test that confirms the replacement behaviour.

Issues:

Closes: #162

And push new tests for ConfigurationUtils
Fix handling of core tests
Bump TW
Add tests for handling configurations.
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented May 13, 2024

  • Publish PR to GitHub Packages

Last commit published: 08aa5c6117d1ca34b61d9d7cdb34018f0c78c819.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #167' // https://github.com/neoforged/NeoGradle/pull/167
        url 'https://prmaven.neoforged.net/NeoGradle/pr167'
        content {
            includeModule('net.neoforged.gradle', 'dsl-neoform')
            includeModule('net.neoforged.gradle.common', 'net.neoforged.gradle.common.gradle.plugin')
            includeModule('net.neoforged.gradle', 'dsl-mixin')
            includeModule('net.neoforged.gradle', 'dsl-vanilla')
            includeModule('net.neoforged.gradle', 'common')
            includeModule('net.neoforged.gradle', 'dsl-common')
            includeModule('net.neoforged.gradle', 'mixin')
            includeModule('net.neoforged.gradle.userdev', 'net.neoforged.gradle.userdev.gradle.plugin')
            includeModule('net.neoforged.gradle', 'dsl-userdev')
            includeModule('net.neoforged.gradle', 'neoform')
            includeModule('net.neoforged.gradle.mixin', 'net.neoforged.gradle.mixin.gradle.plugin')
            includeModule('net.neoforged.gradle.neoform', 'net.neoforged.gradle.neoform.gradle.plugin')
            includeModule('net.neoforged.gradle.vanilla', 'net.neoforged.gradle.vanilla.gradle.plugin')
            includeModule('net.neoforged.gradle', 'platform')
            includeModule('net.neoforged.gradle.platform', 'net.neoforged.gradle.platform.gradle.plugin')
            includeModule('net.neoforged.gradle', 'dsl-platform')
            includeModule('net.neoforged.gradle', 'userdev')
            includeModule('net.neoforged.gradle', 'utils')
            includeModule('net.neoforged.gradle', 'vanilla')
        }
    }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues using multi mod setup with eclipse
2 participants