Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of multiple AccessTransformers in the same project #155

Merged
merged 2 commits into from
Apr 28, 2024

Conversation

marchermans
Copy link
Contributor

This PR fixes an issue introduced with 110, due to the changed handling of filetrees.

Due to the fact that the at applier now already uses file collections we can just pipe that one through and add the script generated files directly without having to deal with the core internals.

Add a set of unit tests to cover access transformer management in userdev.
Add a set of unit tests to cover access transformer management in userdev.
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Apr 28, 2024

  • Publish PR to GitHub Packages

Last commit published: 7e0b0e4597add830c3feae97c2de6356716c3989.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #155' // https://github.com/neoforged/NeoGradle/pull/155
        url 'https://prmaven.neoforged.net/NeoGradle/pr155'
        content {
            includeModule('net.neoforged.gradle.common', 'net.neoforged.gradle.common.gradle.plugin')
            includeModule('net.neoforged.gradle', 'mixin')
            includeModule('net.neoforged.gradle.mixin', 'net.neoforged.gradle.mixin.gradle.plugin')
            includeModule('net.neoforged.gradle', 'common')
            includeModule('net.neoforged.gradle', 'dsl-mixin')
            includeModule('net.neoforged.gradle', 'dsl-common')
            includeModule('net.neoforged.gradle.neoform', 'net.neoforged.gradle.neoform.gradle.plugin')
            includeModule('net.neoforged.gradle', 'dsl-neoform')
            includeModule('net.neoforged.gradle', 'dsl-platform')
            includeModule('net.neoforged.gradle', 'platform')
            includeModule('net.neoforged.gradle', 'dsl-vanilla')
            includeModule('net.neoforged.gradle', 'dsl-userdev')
            includeModule('net.neoforged.gradle', 'neoform')
            includeModule('net.neoforged.gradle.userdev', 'net.neoforged.gradle.userdev.gradle.plugin')
            includeModule('net.neoforged.gradle', 'vanilla')
            includeModule('net.neoforged.gradle', 'utils')
            includeModule('net.neoforged.gradle.vanilla', 'net.neoforged.gradle.vanilla.gradle.plugin')
            includeModule('net.neoforged.gradle.platform', 'net.neoforged.gradle.platform.gradle.plugin')
            includeModule('net.neoforged.gradle', 'userdev')
        }
    }
}

@shartte shartte merged commit f4baaba into NG_7.0 Apr 28, 2024
26 checks passed
@shartte shartte deleted the fix/multi-at branch April 28, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants