Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix string delimiters for Gradle dependencies in README.md #151

Closed
wants to merge 2 commits into from
Closed

Fix string delimiters for Gradle dependencies in README.md #151

wants to merge 2 commits into from

Conversation

xtrm-en
Copy link

@xtrm-en xtrm-en commented Apr 27, 2024

:)

@neoforged-pr-publishing
Copy link

  • Publish PR to GitHub Packages

@Technici4n
Copy link
Member

The " is required for string interpolation, so no.

@Technici4n Technici4n closed this Apr 27, 2024
@xtrm-en
Copy link
Author

xtrm-en commented Apr 27, 2024

So it can be changed to both double-quotes then?

@Technici4n
Copy link
Member

Ahhh yes that is fine

@Technici4n Technici4n reopened this Apr 27, 2024
@xtrm-en
Copy link
Author

xtrm-en commented Apr 27, 2024 •
edited
Loading

Sorry I wasn't thinking of interpolation when changing this 😓

@Technici4n
Copy link
Member

Apparently Orion already fixed this?

@xtrm-en
Copy link
Author

xtrm-en commented May 2, 2024

Yup, case closed

@xtrm-en xtrm-en closed this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xtrm-en @Technici4n @marchermans