Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structure control: styling, layer handlers and attribute forms #266

Open
leendertvanwolfswinkel opened this issue Oct 1, 2024 · 0 comments

Comments

@leendertvanwolfswinkel
Copy link
Collaborator

leendertvanwolfswinkel commented Oct 1, 2024

For an illustration of the workflow from the user perspective, see this powerpoint presentation: https://nelenschuurmans-my.sharepoint.com/:p:/g/personal/leendert_vanwolfswinkel_nelen-schuurmans_nl/ERXFQx4jVU5Iv759Gq0ZEGEB1UReWWhsx4i9XmjS9Jtz_w?e=EubU7W

Measure location​

Attribute form magic

None, except for the tags

Automated actions

Set connection_node_id to the id of the connection node on which this is snapped​

Snapping / topological editing / cascaded deletion options

Use the same logic as we have for other layers, based on the measure_location.connection_node_id -> connection_node.id FK relation​

Memory control / table control

Attribute form magic

  • Tags
  • For table control: the action_table is a three-column table with columns Measured value, Action value 1, Action value 2. Should work the same as the tables we have in other attribute forms (e.g. for tabulated cross-sections)

Automated actions

  • Set the target_type based on whether the memory/table control is placed on a weir, orifice, or pump
  • Fill in the ID of the weir, orifice or pump in the the target_id field
  • If placed on an orifice or weir, snap the geometry to the centroid of the orifice/weir

Snapping / topological editing / cascaded deletion options

Use the same logic as we have for other layers; the relation is a bit more complicated; target_type indicates which table is referenced; target_id indicates which feature in that table is referenced. The memory control should snap to orifice, weir, and pump features. When the orifice, weir, or pump feature is deleted and user also wants to delete all features that reference the deleted objects, the memory control should also be deleted.

Measure map

Attribute form magic

  • Tags

Automated actions

  • When creating a new feature, set the weight to 1 by default
  • Fill in measure_location_id automatically if the measure_map starts at a measure location (also update this automatically if the geometry changes)
  • Fill in control_type and control_id automatically if the measure_map is created or when its geometry is changed

Snapping / topological editing / cascaded deletion options

Similar to those for surface_map. Snap to measure_location, memory_control, and table_control features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant