feat: cherry pick mobile apis #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the ability to get a list of detailed courses based on their keys provided in the newly added `keys` query param in the `GET /courses/v1/courses/` endpoint.
…penedx#34273) * feat: include access serializer into mobile info api view * test: add tests for serializer and view methods * test: move tests to common directory and update test case * fix: cr fixes and use snake case for functions * test: fix additional get call assertion * feat: add required course access messages to mobile endpoint * test: [AXM-229] Improve test coverage * style: [AXM-229] Try to fix linters * fix: remove redundant comment * refactor: change names for the test files --------- Co-authored-by: KyryloKireiev <[email protected]>
* feat: Add course price in mobile enrollment api
…b_url failed tests for Palm Tests will fail again after Palm upgrade
shadinaif
approved these changes
Jun 4, 2024
|
I've done basic testing and it seems to be working fine on staging: We also tested on the mobile app and it was working okay. Multi-tenancy might need some fixes but overall it looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mobile API plugin isn't really working as expected out of the box. So I'm trying with cherry picking the v3 apis from upstream: