feat: update removing priority from nelp koa #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Result on my local environment Before
After
|
andrey-canon
approved these changes
Jan 22, 2024
johanseto
added a commit
that referenced
this pull request
Jan 31, 2024
This reverts commit 288d84f.
johanseto
added a commit
that referenced
this pull request
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migration PR to Nelp
Remove priority from static main tabs to make tab sorting function works correctly
(cherry picked from commit 2ca69ec) (cherry picked from commit c4d5411)
Testing instructions
Having the following pages config in studio.
Check the order of the tabs.
Before
After
PR related
eduNEXT/edunext-platform#678
eduNEXT/edunext-platform#801