Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiple coupons with specifc Keycloak group assignation #14

Closed
marcelovilla opened this issue May 22, 2024 · 1 comment · Fixed by #24
Closed

Support for multiple coupons with specifc Keycloak group assignation #14

marcelovilla opened this issue May 22, 2024 · 1 comment · Fixed by #24

Comments

@marcelovilla
Copy link
Member

Is your feature request related to a problem? Please describe.
Currently, all users are assigned to a single Keycloak group, despite of the coupon they use to register.

Describe the solution you'd like
It would be nice to be able to assign users to different groups, depending on the coupon they use to register. This way, permissions and access to different instance types can be easily controlled.

Describe alternatives you've considered
It was suggested before that the configuration could look like:

coupons:
  - ANT:
    - account_expiration: 30
    - groups = [group1, group2]
    - approved_domains = [quansight.com, *.mil]
  - BAT:
    - account_expiration: 7
    - groups = [group3]
    - approved_domains = [*.mil]

Additional context

@kenafoster
Copy link
Contributor

My only concern is with the upgrade path...

I don't think it's good design to have both the old (global coupon parameters) and new config (per-coupon params) formats available (or if it is, we should talk more about how we could possibly format it

I also don't think it's an option for nebari upgrade to hook into extensions and rewrite config specs the way it does for the core Nebari parameters. (I think it would mean a lot of re-architecting... but I guess it wouldn't hurt to ask the board what they think)

The best way is probably include messaging and a link to documentation when the user runs nebari deploy (or render or validate) since the validation will fail if the updated extension runs against the previous config schema

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants