Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolves #83 gives button variants borders in different states to make button sizing consistent #84

Merged
merged 1 commit into from
Oct 30, 2023
Merged

fix: resolves #83 gives button variants borders in different states to make button sizing consistent #84

merged 1 commit into from
Oct 30, 2023

Conversation

ergusto
Copy link
Member

@ergusto ergusto commented Oct 30, 2023 •
edited
Loading

Resolves #83

@ergusto ergusto requested a review from Ademsk1 October 30, 2023 12:11
Ademsk1
Ademsk1 approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@Ademsk1 Ademsk1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ergusto ergusto merged commit 2eac81e into main Oct 30, 2023
3 of 4 checks passed
@ergusto ergusto deleted the bug/#83-button-variant-borders branch October 30, 2023 12:23
This was referenced Nov 3, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ademsk1 Ademsk1 Ademsk1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] - Button component variants without border should use a same colour border for consistent sizing
2 participants
@ergusto @Ademsk1