Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add in box shadows #63

Merged
merged 8 commits into from
Oct 25, 2023
Merged

feat: add in box shadows #63

merged 8 commits into from
Oct 25, 2023

Conversation

Ademsk1
Copy link
Contributor

@Ademsk1 Ademsk1 commented Oct 25, 2023

Fixes #61
Uses shadow configurations from the Figma. The box radii and widths match that of Tailwind already.

Copy link
Member

@ergusto ergusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the linked issue check to pass, it basically only works with a few reserved words. Can check the docs for it here: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

tailwind.config.js Outdated Show resolved Hide resolved
@Ademsk1 Ademsk1 requested a review from ergusto October 25, 2023 15:29
tailwind.config.js Outdated Show resolved Hide resolved
Copy link
Member

@ergusto ergusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome I think that feels more robust and anyone glancing at our config will know exactly what shadow classes are being generated.

@Ademsk1 Ademsk1 merged commit 0f803ff into main Oct 25, 2023
3 checks passed
@Ademsk1 Ademsk1 deleted the feat/#61_borders branch October 25, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add in borders and shadows
2 participants