Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend font family w/ desired font: inter #62

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Conversation

Ademsk1
Copy link
Contributor

@Ademsk1 Ademsk1 commented Oct 25, 2023

Fixes #60
imports Inter font family and designates it as the default font

Screenshot 2023-10-25 at 12 24 47

Copy link
Member

@ergusto ergusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment but feel free to merge

Copy link
Member

@ergusto ergusto Oct 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely a personal opinion thing and a very, VERY nitpicky/minor point, but in general I think it looks neater and is more readable to leave an empty newline between imports and the rest of the file.

Like:

/** @type {import('tailwindcss').Config} */
import colors from './src/colors'
import defaultTheme from 'tailwindcss/defaultTheme'

module.exports = {
  content: ['./src/**/*.tsx'],

Approving anyway though so up to you if you want to leave it as is or update it.

@Ademsk1 Ademsk1 merged commit 5919ee3 into main Oct 25, 2023
3 checks passed
@Ademsk1 Ademsk1 deleted the feat/#60_fonts branch October 25, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add in fonts
2 participants