Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine and Finish Fastauth metamask Implementation #930

Open
trechriron opened this issue Sep 13, 2023 · 0 comments
Open

Refine and Finish Fastauth metamask Implementation #930

trechriron opened this issue Sep 13, 2023 · 0 comments
Labels
Emerging Tech Emerging Tech flying formation at Pagoda

Comments

@trechriron
Copy link
Collaborator

Description

This is to review PR: wallet-selector: Fastauth metamask

Ammar Humackic
May 18, 2023 at 3:58 AM

I'm moving this into Blocked until necessary work is in place so we can continue this task.

Daryl Collins
May 17, 2023 at 6:58 AM

@Trentin Bergeron We’re still missing some of the APIs necessary for this to work (account creation specifically), and will be adding those as we land the iframe-wallet provider in the next week.

Trentin Bergeron
May 16, 2023 at 1:06 PM

@daryl Collins can you provide guidance here?

Trentin Bergeron
May 4, 2023 at 11:25 AM

From Matt Lockyer;

@trechriron thanks I’ll take a look and address the concerns.

This isn’t ready to merge, but more open for Pagoda to jump in and take across the finish line. Probably should have keep it as draft.

Ideally, it still needs someone from Pagoda with the FastAuth/MetaTransaction APIs expertise to determine:

how many keys do you need generated and where do they need to go?

how is the zero balance account being created and keys being added?

where to put the generated keys and how will they be used in the future? I currently store the generated key in memory as per Daryll’s suggestion of memory > localstorage.

how does this plugin work with the metatransactions plugin? According to what Daryll said as well, the metatransaction plugin would automagically hijack signAndSendTransaction from near-api-js and send these as DelegateActions to the relayer.

I’m sorry to puth the above issues back to your team but I have zero docs, repos, etc… on the above topics and would not know how to finish these items.

@daryl Collins Can you advise so either Matt or SQA could conclude this work? Thanks!

Ammar Humackic
May 4, 2023 at 7:37 AM

@Trentin Bergeron Matt replied on the PR (here), but as he mentioned the input is needed regarding account creation and managing (storing) the keys.

@trechriron trechriron added Emerging Tech Emerging Tech flying formation at Pagoda Near BOS labels Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Emerging Tech Emerging Tech flying formation at Pagoda
Projects
Status: Backlog 🥶
Development

No branches or pull requests

1 participant