You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The interface makes no sense because it does not allow passing args as bytes. This is necessary for any non JSON object parameters.
The type for a function call action is here:
This is extremely limiting because it not only doesn't allow all JSON, only objects, but it doesn't allow borsh or any other serialization format.
If #405 was implemented, there would be at least a workaround for this from a consumer of this library
Not sure why the args parameter in action is not just a buffer, and then you can keep the high-level APIs if you want to auto-serialize an object to JSON
The text was updated successfully, but these errors were encountered:
oh, nevermind, seems like deeply nested the utils used in near-api-js allow passing Uint8Array and it ignores validation. Closing for now because I'm assuming this is workable, assuming all wallet impls use these utils
The interface makes no sense because it does not allow passing args as bytes. This is necessary for any non JSON object parameters.
The type for a function call action is here:
wallet-selector/packages/core/src/lib/wallet/transactions.types.ts
Line 16 in 7e7842d
and the type used in
signAndSendTransaction
:wallet-selector/packages/core/src/lib/wallet/wallet.types.ts
Line 50 in 5da1514
This is extremely limiting because it not only doesn't allow all JSON, only objects, but it doesn't allow borsh or any other serialization format.
If #405 was implemented, there would be at least a workaround for this from a consumer of this library
Not sure why the args parameter in action is not just a buffer, and then you can keep the high-level APIs if you want to auto-serialize an object to JSON
The text was updated successfully, but these errors were encountered: